[PATCH] Don't ucase configured realm

Andrew Bartlett abartlet at samba.org
Thu Apr 8 15:36:07 MDT 2010


On Thu, 2010-04-08 at 10:35 -0400, Benjamin Coddington wrote:
> Has anyone had a chance to look at this, or comment on its odds of 
> inclusion?

File a bug against Samba3 in bugzilla, with the patch attached.  That
way it won't be lost.

I can't see any problems with the latest patch (on the fifth
re-reading), but it may be easier on the next poor soul who needs to
figure out what's going on if you avoid expressions like:

 if (!(*(bool *)ptr = lp_bool(pszParmValue)))

Andrew Bartlett

-- 
Andrew Bartlett                                http://samba.org/~abartlet/
Authentication Developer, Samba Team           http://samba.org
Samba Developer, Cisco Inc.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 190 bytes
Desc: This is a digitally signed message part
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20100409/5913cf1b/attachment.pgp>


More information about the samba-technical mailing list