[PATCH] Fix tsocket on solaris

Andrew Bartlett abartlet at samba.org
Wed Apr 7 15:28:14 MDT 2010


On Wed, 2010-04-07 at 15:34 +0200, Stefan (metze) Metzmacher wrote:
> Hi Andrew,
> 
> > Solaris seems to error out (EINVAL) if sendto has a socklen parameter
> > that isn't the same as the sizeof() for the relevant socket type.
> > 
> > That is, we can't use sizeof(struct sockaddr_storage).
> > 
> > This does not show up on the build farm, as we use socket_wrapper, which
> > plays other games.
> > 
> > Please find attached and review my proposed patch, which instead tries
> > to keep the length alongside the struct sockaddr at all times. 
> 
> The concept looks good, but the patch is incomplete.
> 
> I'll complete it and send it to you.

Thank you so much for looking at this!

This was a funny one, as the cldap_server code would think that the
packet was sent, but down under the covers the EINVAL error was
ignored. 

Andrew Bartlett

-- 
Andrew Bartlett                                http://samba.org/~abartlet/
Authentication Developer, Samba Team           http://samba.org
Samba Developer, Cisco Inc.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 190 bytes
Desc: This is a digitally signed message part
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20100408/02f09464/attachment.pgp>


More information about the samba-technical mailing list