[SCM] Make smbd_lock_socket/smbd_unlock_socket recursive with a ref_count.

Jeremy Allison jra at samba.org
Thu Apr 1 09:30:08 MDT 2010


On Thu, Apr 01, 2010 at 01:53:29PM +0200, Andreas Schneider wrote:
> On Thursday 01 April 2010 11:50:58 Andreas Schneider wrote:
> > On Thursday 01 April 2010 02:42:06 Jeremy Allison wrote:
> > > The branch, master has been updated
> > > 
> > >        via  6800fdb... Make smbd_lock_socket/smbd_unlock_socket recursive
> > > 
> > > with a ref_count. from  bb54089... s3: Merge French translation for
> > > pam_winbind after review
> > > 
> > > http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
> > > 
> > > 
> > > - Log -----------------------------------------------------------------
> > > commit 6800fdbb81130b79c2e077e9a7fcbe2d5e0813cb
> > > Author: Jeremy Allison <jra at samba.org>
> > > Date:   Wed Mar 31 17:40:30 2010 -0700
> > > 
> > >     Make smbd_lock_socket/smbd_unlock_socket recursive with a ref_count.
> > >     
> > >     As these always call exit_server, make that part of the function.
> > >     Use _internal functions for the echo client.
> > >     
> > >     Metze please check !
> > >     
> > >     Jeremy.
> > 
> > With this commit my smbd doesn't accept a rpc connection anymore.
> > 
> > asn at magrathea:~/workspace/projects/samba/master/source3> bin/rpcclient -I
> > 127.0.0.1 -U asn magrathea
> > Enter asn's password:
> > cli_session_setup_blob: cli->max_xmit too small (was 0, need minimum 81)
> > failed session setup with NT_STATUS_INVALID_PARAMETER
> > Cannot connect to server.  Error was NT_STATUS_INVALID_PARAMETER
> > 
> > It works if I revert this patch.
> 
> Or if I run 'git clean -f -x' and build everything from scratch. I like this 
> build system ...

Yeah, I changed the global struct size, which everything
depends on - but the build system doesn't know that everything
needs rebuilding if globals.c is changed.

Jeremy.


More information about the samba-technical mailing list