[SCM] Samba Shared Repository - branch master updated - release-4-0-0alpha8-1448-gfb91464

Jelmer Vernooij jelmer at samba.org
Tue Sep 22 06:45:32 MDT 2009

Hi Matthias,

Matthias Dieter Wallnöfer wrote:
> I put this in when you were on vacations (I think). I had to patch
> manually since the patchfile didn't apply anymore.
> Okay, the WMI management is broken at the moment, but it's good to
> have the patch under version control since standalone patches - you
> know - do often not work anymore on say a half-year newer code version.
> But I'm fine if you want to revert it for now in the "master" branch -
> but I'd like to see it picked up somewhere. But couldn't you do a
> backmerge to your actual "WMI" repository and work on it? Then when
> you merge the full WMI code from the repo - we had it in.
Please revert it for now. I much prefer a patch that no longer applies
to a patch that further breaks the existing code - and that's likely,
given that it can't have been tested. Applying this patch manually later
could take more time, but on the other hand so would take debugging an
issue that could have been introduced by pushing it now.


> Jelmer Vernooij schrieb:
>> Hi Matthias,
>> Matthias Dieter Wallnöfer wrote:
>>> The branch, master has been updated
>>>        via  fb914640ad656b146f732ab33063575e2e47e37c (commit)
>>>       from  5ce12a05658ce03bf6414c15f20c28e125897dc2 (commit)
>>> http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
>>> - Log -----------------------------------------------------------------
>>> commit fb914640ad656b146f732ab33063575e2e47e37c
>>> Author: Dmitry Karasik <dmitry at karasik.eu.org>
>>> Date:   Mon Sep 7 14:08:16 2009 +0200
>>>     s4:wmic - Output enhancements
>>>         Outputs shouldn't clash with metadata characters (|,()),
>>> special characters
>>>     should be escaped, "NULL" values should be reported as "(null)"
>>> string.
>>>         For the full explaination look at bug #6076.
>> This patch introduces static 2048-byte buffers which are used when
>> escaping data received from a remote host *and* there's no boundary
>> checking whatsoever. Furthermore, the code that this is in is broken at
>> the moment so neither of you could have tested it. I specifically asked
>> Dmitry to file a bug about it for that reason
>> (http://lists.samba.org/archive/samba-technical/2009-January/062992.html).
>> Cheers,
>> Jelmer

More information about the samba-technical mailing list