[SCM] Samba Shared Repository - branch master updated - release-4-0-0alpha8-942-g7bc566a

Jelmer Vernooij jelmer at samba.org
Mon Sep 21 15:49:47 MDT 2009


Hi Andrew, Oliver,

Sorry if this has already been fixed since..

Andrew Bartlett wrote:
> diff --git a/source4/scripting/python/samba/provision.py b/source4/scripting/python/samba/provision.py
> index 8a7ed6a..39c3fff 100644
> --- a/source4/scripting/python/samba/provision.py
> +++ b/source4/scripting/python/samba/provision.py
> @@ -36,6 +36,7 @@ import socket
>  import param
>  import registry
>  import samba
> +import subprocess
>  from auth import system_session
>  from samba import version, Ldb, substitute_var, valid_netbios_name, check_all_substituted, \
>    DS_BEHAVIOR_WIN2008
subprocess is a relatively new Python package, depending on it would
mean that we can't support some of the older python versions that we
support at the moment (it's >= 2.4 IIRC). Do we really need one of the
features from  subprocess or could we perhaps fall back to something
also present in older versions of Python (os.popen2?).

Cheers,

Jelmer



More information about the samba-technical mailing list