[SCM] Samba Shared Repository - branch master updated - release-4-0-0alpha8-437-ge16a2a1

Jelmer Vernooij jelmer at samba.org
Mon Sep 21 15:36:34 MDT 2009


Hi Andrew,

Andrew Bartlett wrote:
> diff --git a/source4/scripting/python/pyglue.c b/source4/scripting/python/pyglue.c
> index 5816d96..c6b731c 100644
> --- a/source4/scripting/python/pyglue.c
> +++ b/source4/scripting/python/pyglue.c
> @@ -204,6 +204,63 @@ static PyObject *py_dsdb_set_ntds_invocation_id(PyObject *self, PyObject *args)
>  	Py_RETURN_NONE;
>  }
>  
> +static PyObject *py_dsdb_set_opaque_integer(PyObject *self, PyObject *args)
> +{
> +	PyObject *py_ldb;
> +	int value;
> +	int *old_val, *new_val;
> +	char *py_opaque_name, *opaque_name_talloc;
> +	struct ldb_context *ldb;
> +	TALLOC_CTX *tmp_ctx;
> +
> +	if (!PyArg_ParseTuple(args, "Osi", &py_ldb, &py_opaque_name, &value))
> +		return NULL;
>   
^^ Since this is Python, we could just check if the type is of
PyInt_Type in py_dsdb_set_opaque() and special case that? Is it an
intentional choice to have a separate function?

Cheers,

Jelmer



More information about the samba-technical mailing list