[PATCH] lib/tevent: a cleaner fix for be4ac227842530d484659f2db683453366326d8b segv

Volker Lendecke Volker.Lendecke at SerNet.DE
Tue Sep 22 02:54:16 MDT 2009


On Tue, Sep 22, 2009 at 10:32:10AM +0930, Rusty Russell wrote:
> Revert 23abcd2318c69753aa2a144e1dc0f9cf9efdb705 and fix logic bug.
> 
> The current code loops through the event contexts, when it sees a different
> one, it notifies the current one (ev) and updates ev to point to the new one.
> 
> This is dumb, because:
> (1) ev starts as NULL, so this code crashes, and
> (2) The final context will not be notified.
> 
> The correct fix for this is to update ev to the new one, then notify it.
> Volker's fix works because we currently always have one event context.

Thanks, pushed.

Volker
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: Digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20090922/4c442af1/attachment.pgp>


More information about the samba-technical mailing list