[SCM] Samba Shared Repository - branch master updated - release-4-0-0alpha8-1426-g231d276

Jelmer Vernooij jelmer at samba.org
Mon Sep 21 08:23:56 MDT 2009

Hi Matthias,

Thanks for improving the error reporting in provision!

Matthias Dieter Wallnöfer wrote:
> +class ProvisioningError(ValueError):
> +  pass
> +
^^^ Please derive from the Exception baseclass - ValueError is about
arguments with incorrect values being passed, so not relevant here.

Also, please use 4-space indentation in Python code, and use docstrings
(that way you don't need "pass" there).



More information about the samba-technical mailing list