blackbox:test_kinit - Remove the "-H" (hive) parameter

Matthias Dieter Wallnöfer mdw at samba.org
Mon Sep 21 03:44:13 MDT 2009


Hi Andrew,

I'll reintroduce the "-H" argument (I didn't understand that it was 
really needed) but on all scripts. Since the previous behaviour (some 
had it, some not) I found *very* unclear (therefore I removed them).

Matthias

Andrew Bartlett schrieb:
> On Sun, 2009-09-20 at 17:04 -0500, Matthias Dieter Wallnöfer wrote:
>
>   
>> commit d4389a230b6aea5a0b2a98e255b14a59c8248b0b
>> Author: Matthias Dieter Wallnöfer <mwallnoefer at yahoo.de>
>> Date:   Sun Sep 20 23:07:22 2009 +0200
>>
>>     blackbox:test_kinit - Remove the "-H" (hive) parameter
>>     
>>     The "enableaccount" script works only on local LDB anymore - therefore remove
>>     this parameter.
>>     
>
>   
>> diff --git a/testprogs/blackbox/test_kinit.sh b/testprogs/blackbox/test_kinit.sh
>> index 91f21f4..0a15802 100755
>> --- a/testprogs/blackbox/test_kinit.sh
>> +++ b/testprogs/blackbox/test_kinit.sh
>> @@ -69,7 +69,7 @@ echo $USERPASS > ./tmpuserpassfile
>>  
>>  testit "set user password with kerberos ccache" $VALGRIND $net password set $DOMAIN\\nettestuser $USERPASS $CONFIGURATION  -k yes $@ || failed=`expr $failed + 1`
>>  
>> -testit "enable user with kerberos cache" $VALGRIND $enableaccount nettestuser -H ldap://$SERVER -k yes $@ || failed=`expr $failed + 1`
>> +testit "enable user with kerberos cache" $VALGRIND $enableaccount nettestuser -k yes $@ || failed=`expr $failed + 1`
>>  
>>  KRB5CCNAME="$PREFIX/tmpuserccache"
>>  export KRB5CCNAME
>>     
>
> The reason this used -H in the past is to allow it, in principal, to run
> against a remote server.  This means that we can then verify that it is
> in fact a valid test.  
>
> Can you please put the -H options back?  They were there on purpose.
>
> Andrew Bartlett
>
>   




More information about the samba-technical mailing list