[SCM] Samba Shared Repository - branch master updated - tevent-0-9-8-196-gf74e8c2

Matthias Dieter Wallnöfer mwallnoefer at yahoo.de
Fri Sep 11 09:34:48 MDT 2009

Hi Andrew,

I inspected the changelog - and since I'm now a bit more familiar with 
async requests I strongly wanted to review this code fragment. I had in 
mind: to delete a "general" "talloc_free" and move it only in a "if" 
branch  - that can't be enough :-) .


Andrew Kroeger schrieb:
> Matthias Dieter Wallnöfer wrote:
>> commit f74e8c266f43d0c640ab8068d28a1b197164d548
>> Author: Matthias Dieter Wallnöfer <mwallnoefer at yahoo.de>
>> Date:   Fri Sep 11 13:35:55 2009 +0200
>>     s4:ldb_map_outbound - fix memory leak
>>         Patch from Andrew Kroeger wasn't fully correct - we need a 
>> "talloc_free" after
>>     the "if (ac->r_current == NULL)" statement.
> Matthias:
> Thank you!
> I got too focused on solving the problem I found and lost sight of the 
> overall issue.
> May I ask if you found this issue via inspection (just looking at the 
> code) or if you are using some tool that flags such issues?
> Sincerely,
> Andrew Kroeger

More information about the samba-technical mailing list