[PATCH] s4:srvsvc: Fix logic on error checking.

Andrew Kroeger andrew at id10ts.net
Mon Sep 7 06:52:37 MDT 2009


---
 source4/rpc_server/srvsvc/dcesrv_srvsvc.c |   12 ++++++------
 1 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/source4/rpc_server/srvsvc/dcesrv_srvsvc.c b/source4/rpc_server/srvsvc/dcesrv_srvsvc.c
index f33c49a..be804ba 100644
--- a/source4/rpc_server/srvsvc/dcesrv_srvsvc.c
+++ b/source4/rpc_server/srvsvc/dcesrv_srvsvc.c
@@ -1246,7 +1246,7 @@ static WERROR dcesrv_srvsvc_NetShareSetInfo(struct dcesrv_call_state *dce_call,
 					0,
 					0,
 					NULL);
-		if (W_ERROR_EQUAL(status, WERR_OK)) {
+		if (!W_ERROR_EQUAL(status, WERR_OK)) {
 			return status;
 		}
 		break;
@@ -1263,7 +1263,7 @@ static WERROR dcesrv_srvsvc_NetShareSetInfo(struct dcesrv_call_state *dce_call,
 					0,
 					0,
 					NULL);
-		if (W_ERROR_EQUAL(status, WERR_OK)) {
+		if (!W_ERROR_EQUAL(status, WERR_OK)) {
 			return status;
 		}
 		break;
@@ -1280,7 +1280,7 @@ static WERROR dcesrv_srvsvc_NetShareSetInfo(struct dcesrv_call_state *dce_call,
 					r->in.info->info2->max_users,
 					0,
 					NULL);
-		if (W_ERROR_EQUAL(status, WERR_OK)) {
+		if (!W_ERROR_EQUAL(status, WERR_OK)) {
 			return status;
 		}
 		break;
@@ -1297,7 +1297,7 @@ static WERROR dcesrv_srvsvc_NetShareSetInfo(struct dcesrv_call_state *dce_call,
 					0,
 					r->in.info->info501->csc_policy,
 					NULL);
-		if (W_ERROR_EQUAL(status, WERR_OK)) {
+		if (!W_ERROR_EQUAL(status, WERR_OK)) {
 			return status;
 		}
 		break;
@@ -1314,7 +1314,7 @@ static WERROR dcesrv_srvsvc_NetShareSetInfo(struct dcesrv_call_state *dce_call,
 					r->in.info->info502->max_users,
 					0,
 					r->in.info->info502->sd_buf.sd);
-		if (W_ERROR_EQUAL(status, WERR_OK)) {
+		if (!W_ERROR_EQUAL(status, WERR_OK)) {
 			return status;
 		}
 		break;
@@ -1331,7 +1331,7 @@ static WERROR dcesrv_srvsvc_NetShareSetInfo(struct dcesrv_call_state *dce_call,
 					0,
 					0,
 					NULL);
-		if (W_ERROR_EQUAL(status, WERR_OK)) {
+		if (!W_ERROR_EQUAL(status, WERR_OK)) {
 			return status;
 		}
 		break;
-- 
1.6.0.6


--------------030803080908090006050009--


More information about the samba-technical mailing list