[PATCH] Basic Ldb unittests involving nTSecurityDescriptor

Andrew Bartlett abartlet at samba.org
Tue Sep 8 07:55:14 MDT 2009


On Tue, 2009-09-08 at 16:37 +0300, Zahari zahariev wrote:
> Jelmer Vernooij wrote: 
> > On Tue, Sep 08, 2009 at 03:31:42PM +1000, Andrew Bartlett wrote:
> >   
> > > On Tue, 2009-09-08 at 07:23 +0300, Zahari Zahariev wrote:
> > >     
> > > > Should we though separate this not working case in a different unittest or if we put it in the 'known' file it will be the whole ldap.python file?
> > > >       
> > 
> >   
> > > That is for you to figure out :-)
> > >     
> > 
> >   
> > > I hope jelmer's unit test stuff is good enough to handle a specific test
> > > failing.
> > >     
> > 
> > It is indeed possible to handle a specific test failing, as long as
> > that test failure is reported properly using subunit (which is the
> > case for the Python tests).
> > 
> > Cheers,
> > 
> > Jelmer
> >   
> Hello Jelmer & Samba team,
> 
> This is the latest update I have managed to prepare for this patch. 
> 
> The 'negative' test that still does not behave with Samba4 the way it
> does with Active Directory is in its own test function so it can be
> easily excluded with a regex. All other two test functions behave
> exactly the same way with both AD and Samba4. I have checked that make
> test is OK as long as the test function
> 'test_security_descriptor_add_neg()' is not executed.

Surely you want that executed, but for it's failure not to fail the
whole 'make test'?

> I hope these important basic tests for security descriptor handling
> finally make their way into smamba-master.
> 
> Cheers! 
-- 
Andrew Bartlett                                http://samba.org/~abartlet/
Authentication Developer, Samba Team           http://samba.org
Samba Developer, Cisco Inc.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20090908/ee2d36a2/attachment.pgp>


More information about the samba-technical mailing list