ber_read_OID_String patch

Stefan (metze) Metzmacher metze at
Tue Sep 8 06:47:06 MDT 2009

Kamen Mazdrashki schrieb:
> Hi Metze,
> On Tue, Sep 8, 2009 at 13:33, Stefan (metze) Metzmacher<metze at> wrote:
>> 095c690ca1184a880c81f1c1
>> -       typedef [nopush,nopull] struct {
>> -
>> [range(0,10000),value(ndr_size_drsuapi_DsReplicaOID_oid(oid, 0))]
>> uint32 __ndr_size;
>> -               [size_is(__ndr_size),charset(DOS)] uint8 *oid; /* it's
>> encoded with asn1_write_OID_String() */
>> +       typedef [noprint] struct {
>> +               [range(0,10000)] uint32 length;
>> +               [size_is(length)] uint8 *oid;
>>         } drsuapi_DsReplicaOID;
>> please rename oid to binary_oid and fix all callers to cope with binary
>> data. With this patch you'll generate some compilers and bugs, because
>> we now pass a binary buffer as string (while casting uint8_t * to char
>> *).
>> I fear the patch will be much larger...
> I was just about to ask you for allowing me to implement this change :)
> I haven't done an impact analysis yet, but at first sight, it seems it won't
> be a small patch.
> Btw, I was planning to do this after the plugfest - right now I want to spent
> most of my time on chasing issues and writing tests so you have more issues
> to talk about with MS guys.
> Is this plan OK with you?

sure, but please make sure that no one commits this half finished
changes to master. This means we could not commit some of the tests too.

Maybe I have some time during the conferences to code this...


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 252 bytes
Desc: OpenPGP digital signature
URL: <>

More information about the samba-technical mailing list