[SCM] Samba Shared Repository - branch master updated - release-4-0-0alpha8-1414-g43c766a

Stefan (metze) Metzmacher metze at samba.org
Sun Sep 6 23:25:47 MDT 2009

Hi Jeremy,

> - Log -----------------------------------------------------------------
> commit 43c766a14a5eeed80e57bae9fde21eb2b542c209
> Author: Jeremy Allison <jra at samba.org>
> Date:   Sun Sep 6 21:38:50 2009 -0700
>     Fix bug 6673 - smbpasswd does not work with "unix password sync = yes".
>     Revert change from 3.3 -> 3.4 with read_socket_with_timeout changed
>     from sys_read() to sys_recv(). read_socket_with_timeout() is called
>     with non-fd's (with a pty in chgpasswd.c and with a disk file in
>     lib/dbwrap_file.c via read_data()). recv works for the disk file,
>     but not the pty. Change the name of read_socket_with_timeout() to
>     read_fd_with_timeout() to make this clear (and add comments).
>     Jeremy.

I think we should have 2 functions then.
We need to use sys_recv() on sockets, otherwise our socket_wrapper pcap
support doesn't work.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 252 bytes
Desc: OpenPGP digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20090907/7b6141f9/attachment.pgp>

More information about the samba-technical mailing list