[PATCH 3/5] tdb: reset tdb->fd to -1 in tdb_close()
kirr at mns.spb.ru
Thu Oct 29 04:01:56 MDT 2009
On Thu, Oct 29, 2009 at 10:15:49AM +1030, Rusty Russell wrote:
> On Thu, 29 Oct 2009 01:06:06 am Kirill Smelkov wrote:
> > On Mon, Oct 26, 2009 at 01:41:20PM +1030, Rusty Russell wrote:
> > > On Thu, 22 Oct 2009 03:48:56 am Kirill Smelkov wrote:
> > > > So that erroneous double tdb_close() calls do not try to close() same
> > > > fd again. This is like SAFE_FREE() but for fd.
> > >
> > > Hi Kirill,
> > >
> > > These patches look good. This one of course doesn't allow multiple
> > > tdb_close(), since it frees the tdb context anyway. But the extra paranoia
> > > can't hurt.
> > Rusty, thanks for your reply.
> > I see these patches are still not merged in, so how does one then
> > actually get patches applied to samba.git?
> > Maybe I need to somehow rework them?
> No, your patches were fine! I just needed to commit them, check it was all OK
> and push. Done now.
Ah, I see, thanks.
> Thanks for the excellent series!
Come on, Rusty, it's just trivia :)
More information about the samba-technical