ldb python bindungs - better use the "enum ldb_scope" for the search scope rather than "int"

Andrew Bartlett abartlet at samba.org
Tue Oct 27 16:48:20 MDT 2009

On Tue, 2009-10-27 at 12:18 +0000, Jelmer Vernooij wrote:
> Hi Matthias,

> Please revert this - this is intentional. PyArg_ParseTupleAndKeywords parses 
> and sets an integer, not an ldb_scope enum. The values it reads are not 
> necessarily valid ldb_scope values.


The reason this is a worry is that the size of an enum and the size of
'int' may differ, and this reverts a patch tridge put in only very
recently to fix python on 64 bit machines.

See commit c45a81ecf3229762b7074891b86d894c27489180

Perhaps you could continue to put your cleanup patches past another team
member, so they may advise on areas of history or complexity that you
haven't picked up on yet, just as you are on the const patches?

I know these changes seem trivial and safe, but we seem to be doing the
reviews (and finding issues) once they are in the tree, rather than
before they are merged. 

(And yes, I've had my own suite of issues with patches that have been in
the tree without enough review and testing.  This is something we all
need to improve on).


Andrew Bartlett

Andrew Bartlett                                http://samba.org/~abartlet/
Authentication Developer, Samba Team           http://samba.org
Samba Developer, Cisco Inc.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20091028/a03acd29/attachment.pgp>

More information about the samba-technical mailing list