Remaining "cast"/"const" patches

Matthias Dieter Wallnöfer mdw at
Sun Oct 18 10:25:57 MDT 2009


I finished the split-up. It's not reasonable to post the patches as attachment - so they're only in my private repo. Maybe you like to write the filenames or patch titles of those which look okay.


--- Matthias Dieter Wallnöfer <mdw at> schrieb am Fr, 16.10.2009:

Von: Matthias Dieter Wallnöfer <mdw at>
Betreff: Re: Remaining "cast"/"const" patches
An: "Andrew Bartlett" <abartlet at>
CC: "Samba Technical Mailinglist" <samba-technical at>
Datum: Freitag, 16. Oktober 2009, 12:32


well - okay - I'll definitely split them up. I see it's too much work in one commit.


--- Andrew Bartlett <abartlet at> schrieb am Fr, 16.10.2009:

For as long as you continue to post these as large 'fix things' patches,
we will have to continue to reject them.  I'm sorry it has to be this
way, and I know it is a *lot* of work to split up the patches, but it is
even more work to track down problems later, and Volker is right to be
concerned when there are behaviour changes mixed in with casts. 

You even just have other stylistic changes mixed in with these patches.

A change such as the one to nbtname might be correct, but it is also a
great example of why it needs to be separated, so it can be clearly
explained in it's own commit message, and clearly understood independent
from other changes.  This same need applies to almost every change in
this series.  

Perhaps you don't know how to use 'git add -i' to create small patches
from one file?  (A git guru on #samba-technical will no doubt be glad to
give you a tutorial). 

Andrew Bartlett

Andrew Bartlett                      
Authentication Developer, Samba Team 
Samba Developer, Cisco Inc.


More information about the samba-technical mailing list