Remaining "cast"/"const" patches
abartlet at samba.org
Thu Oct 15 16:01:53 MDT 2009
On Thu, 2009-10-15 at 17:07 +0200, Matthias Dieter Wallnöfer wrote:
> Hi abartlet & list,
> here is the last version of my compiler warning patches (casts, consts)
> for s4 and for common code. The s3 only version I dropped since there
> were some concerns about the reasonability (well - there don't exist
> those kind of warnings at the moment so I agree that it wouldn't be
> really needed there).
> I propose them here for review as decided with abartlet. Naturally I
> will consider also other requests and concerns. I just want to have this
> work finished soon.
For as long as you continue to post these as large 'fix things' patches,
we will have to continue to reject them. I'm sorry it has to be this
way, and I know it is a *lot* of work to split up the patches, but it is
even more work to track down problems later, and Volker is right to be
concerned when there are behaviour changes mixed in with casts.
You even just have other stylistic changes mixed in with these patches.
A change such as the one to nbtname might be correct, but it is also a
great example of why it needs to be separated, so it can be clearly
explained in it's own commit message, and clearly understood independent
from other changes. This same need applies to almost every change in
Perhaps you don't know how to use 'git add -i' to create small patches
from one file? (A git guru on #samba-technical will no doubt be glad to
give you a tutorial).
Andrew Bartlett http://samba.org/~abartlet/
Authentication Developer, Samba Team http://samba.org
Samba Developer, Cisco Inc.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 189 bytes
Desc: This is a digitally signed message part
More information about the samba-technical