AW: changes to wbclient.h (Re: [SCM] Samba Shared Repository - branch master updated)

[Matthias Dieter Wallnöfer]

Hi Simo,

would you be satisfied with the "defines" solution as metze pointed out in another post of the thread? If yes I would implement this tomorrow in a patch.

Matthias

--- simo <idra at samba.org> schrieb am Sa, 10.10.2009:

Von: simo <idra at samba.org>
Betreff: Re: AW: changes to wbclient.h (Re: [SCM] Samba Shared Repository - branch master updated)
An: "Matthias Dieter Wallnöfer" <mdw at samba.org>
CC: samba-technical at lists.samba.org
Datum: Samstag, 10. Oktober 2009, 14:56

On Fri, 2009-10-09 at 18:17 +0000, Matthias Dieter Wallnöfer wrote:
> Hi Stefan,
> 
> yeah I know that my change is problematic. But I got a request from
> Günther to adapt the values as they're specified in "samr.idl" to
> allow further error case additions in winbind.
> 
> In particular consider the value 0: previous it was an "other" error
> but a lookup in the MS-SAMR documentation pointed out that it should
> mean no error at all.
> 
> So I'd strongly prefer to keep the patch in this form to have it right
> - from now on . I know it is cumbersome to break the API and external
> code has to be adapted - but personally I don't see a better solution.

Matthias,
this API was built with the primary reason to decouple winbind from
clients in a way that would not require clients to closely track winbind
changes.
So, no, I don't think a gratuitous change is a good idea, certainly not
the "best" solution.

Simo.

-- 
Simo Sorce
Samba Team GPL Compliance Officer <simo at samba.org>
Principal Software Engineer at Red Hat, Inc. <simo at redhat.com>