AW: changes to wbclient.h (Re: [SCM] Samba Shared Repository - branch master updated)

[Matthias Dieter Wallnöfer]

Hi Stefan,

yeah I know that my change is problematic. But I got a request from Günther to adapt the values as they're specified in "samr.idl" to allow further error case additions in winbind.

In particular consider the value 0: previous it was an "other" error but a lookup in the MS-SAMR documentation pointed out that it should mean no error at all.

So I'd strongly prefer to keep the patch in this form to have it right - from now on . I know it is cumbersome to break the API and external code has to be adapted - but personally I don't see a better solution.

Matthias

--- Stefan (metze) Metzmacher <metze at samba.org> schrieb am Fr, 9.10.2009:

Von: Stefan (metze) Metzmacher <metze at samba.org>
Betreff: changes to wbclient.h (Re: [SCM] Samba Shared Repository - branch master updated)
An: samba-technical at lists.samba.org
CC: samba-cvs at samba.org
Datum: Freitag, 9. Oktober 2009, 17:35

Hi Matthias,
> diff --git a/nsswitch/libwbclient/wbclient.h b/nsswitch/libwbclient/wbclient.h
> index 4dc6d23..ced82d8 100644
> --- a/nsswitch/libwbclient/wbclient.h
> +++ b/nsswitch/libwbclient/wbclient.h
> @@ -427,10 +427,15 @@ struct wbcUserPasswordPolicyInfo {
>   **/
>  
>  enum wbcPasswordChangeRejectReason {
> -    WBC_PWD_CHANGE_REJECT_OTHER=0,
> -    WBC_PWD_CHANGE_REJECT_TOO_SHORT=1,
> -    WBC_PWD_CHANGE_REJECT_IN_HISTORY=2,
> -    WBC_PWD_CHANGE_REJECT_COMPLEXITY=5
> +    WBC_PWD_CHANGE_NO_ERROR=0,
> +    WBC_PWD_CHANGE_PASSWORD_TOO_SHORT=1,
> +    WBC_PWD_CHANGE_PWD_IN_HISTORY=2,
> +    WBC_PWD_CHANGE_USERNAME_IN_PASSWORD=3,
> +    WBC_PWD_CHANGE_FULLNAME_IN_PASSWORD=4,
> +    WBC_PWD_CHANGE_NOT_COMPLEX=5,
> +    WBC_PWD_CHANGE_MACHINE_NOT_DEFAULT=6,
> +    WBC_PWD_CHANGE_FAILED_BY_FILTER=7,
> +    WBC_PWD_CHANGE_PASSWORD_TOO_LONG=8
>  };

wbclient.h is a public interface, where we can't change existing code!

At least we need to add the old enum values as defines to the new ones.

metze