abartlet at samba.org
Tue Oct 6 22:11:17 MDT 2009
On Tue, 2009-10-06 at 15:23 +0300, Kamen Mazdrashki wrote:
> Andrew, Metze,
> Please find attached few patches on DRS:prefixMap refactoring.
> Patches from 0001 to 0006 redefine IDL definition for
> drsuapi_DsReplicaOID structure.
> Changes are propagated in code base.
> Note: Those changes does not add any value to current implementation.
> Implementation should work just as before - i.e. partial-OIDs are
> not handled correctly.
> As for now, the only benefit is torture tests are working
> with prefixMaps with partial-OIDs as well.
> My next step here is to reimplement prefixMap functionality in
> separate file (module). PrefixMap functionality is to be
> implemented as described in MS-DRSR documentation - currently
> there is such implementation in RPC-DSSYNC test and it is
> working fine (please see next patches).
> Patches from 0007 to 0012 implements:
> 1. new torture module DRSUAPI_TESTS. Intention is all DRS-related
> tests to be implemented in this module.
> My next step is to move RPC-DRSUAPI tests here. Those test cases
> are to be renamed and prefix will be DRS-RPC...
> I indent also to implement some internal unit tests for DRS implementation.
> 2. RPC-DSSYNC test is extended little bit. All attributes returned in
> replication are decoded and verified against the remote server we are
> replicating from. Decoded attributes are dumped out as debug messages.
As long as they don't break the vampire work tridge is doing, and keep
'make test' passing, I'm happy to see these merged.
I like the approach of changing the print function rather than the
pull/push function to cope with the partial OIDs. (But metze may wish
Andrew Bartlett http://samba.org/~abartlet/
Authentication Developer, Samba Team http://samba.org
Samba Developer, Cisco Inc.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 189 bytes
Desc: This is a digitally signed message part
More information about the samba-technical