[SAMBA4] Help merge my ldb-fixes branch

Matthias Dieter Wallnöfer mdw at samba.org
Fri Oct 2 16:22:35 MDT 2009


latest state: merged most part of the patches (the last ones are located 
in my "abartlet" private branch - they will require more detailed 
tests), enhanced the ldap.py testsuite. The most recent one you need to 
rework - it isn't complete (your new control isn't accepted by the 
partition module - so the "ldb_tdb" backend moans). Also I've still to 
fix a small glitch with the "rdn_name" module (renames - due to the 
"special" attributes RDN, "name" checks).


Andrew Bartlett schrieb:
> Matthias,
> While at the plugfest at Microsoft a week ago now, I did a lot of work
> to make our LDAP server better. 
> However, while it now passes more of Microsoft's testsuites, I don't
> have Samba tests for any of the changes.  As such, we will break this
> work in future, and I'll only find out next time I get my hands on the
> MS tests.
> I wondered if you or someone on the list might like to cherry-pick some
> of the changes and write tests in ldap.py for them so they can be pushed
> to master?  (Ignore the changes under lib/ldb)
> They are in git://git.samba.org/abartlet/samba.git ldb-fixes
> I know you have changes for samldb and ldap.py in store.  Perhaps you
> might want to take a close look at my changes and see how to best
> integrate new tests and these new requirements into that work?  
> BTW, in retrospect I wish I had looked closer at your changes before the
> week at MS, as many of the modify tests failed (as you know, many things
> are illegal to modify), and it seems you now have a way to handle that.
> Nice work!
> Andrew Bartlett

More information about the samba-technical mailing list