s4-drs: cope with bogus empty attributes from w2k8-r2 (Re: [SCM] Samba Shared Repository - branch master updated)

[Stefan (metze) Metzmacher]

tridge at samba.org schrieb:
> Hi Metze,
> 
>  > > +	/* delete any empty elements */
>  > > +	for (i=0; i < msg->num_elements; i++) {
>  > > +		if (msg->elements[i].name == NULL) {
>  > > +			ldb_msg_remove_element(msg, &msg->elements[i]);
>  > > +			i--;
>  > > +		}
>  > > +	}
>  > > +
>  > 
>  > We need to be careful about this, an empty element means
>  > we should remove existing values.
>  > If remove the empty ones here, we need to let the repl_meta_data module
>  > remove them based on the received meta_data array.
> 
> my comment in the above is perhaps misleading. I'm removing "empty"
> ones that have a NULL name. It only gets a NULL name when the attid is
> invalid (not in the prefixmap) and it also has no elements.

Ah, ok.

do you know the attid space is splitted into multiple parts,
not all ids are mapped via the prefix map, some are also mapped
to static values defined with the msDs-intID (or a similar name)
in the schema objects.

Are the attid's different each time you run the test?

metze

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 260 bytes
Desc: OpenPGP digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20091130/ad75cd04/attachment.pgp>