Failing tests after poisoning free memory

Kamen Mazdrashki kamenim at gmail.com
Wed Nov 25 17:32:39 MST 2009


Hi,

A week ago I found a bug in 'str_list_unique' function which was there
for a year now
despite the fact we have a test for this function.
After implementing a little bit more complex test for this function,
the bug was
reproducible only in rare cases.
For reference, please look at commits:
http://git.samba.org/?p=samba.git;a=commit;h=b7839b73b10746c374ca2ed96eb152fa3a03e66a
http://git.samba.org/?p=samba.git;a=commit;h=5b75201dbb9f2e6799fd5c3eee8da6230caee96c

This inspired me to try to find out a way to always reproduce such a
bugs, which led me
to the talloc patch attached - basically, memory being freed or
reallocated is filled with garbage.
(Note: I am not proposing this patch to be included in master as it
makes Samba way too slow
and it is far from being complete).

After running 'make test' few tests are now 100% failing (attached: summary):
RAW-STREAMS
SMB2-STREAMS
LOCAL-TDR

Unfortunately I am not familiar with this part of the code /sounds
like I am familiar with any part
of the code base right :)/
So if anyone is interested in looking into this issue, that would be great :)

-- 
CU,
Kamen Mazdrashki
kamen.mazdrashki at postpath.com
http://repo.or.cz/w/Samba/kamenim.git
-------------------------------------
CISCO SYSTEMS BULGARIA EOOD
http://www.cisco.com/global/BG/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: summary
Type: application/octet-stream
Size: 9218 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20091126/ed80bb63/attachment.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-talloc-Squash-memory-not-used-anymore-and-newly-all.patch
Type: application/octet-stream
Size: 3692 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20091126/ed80bb63/attachment-0001.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: test_01.log.gz
Type: application/x-gzip
Size: 9946 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20091126/ed80bb63/attachment.bin>


More information about the samba-technical mailing list