[PATCH] s4:drs Create connection object (nTDSConnection)

Crístian Viana cristiandeives at gmail.com
Tue Nov 24 22:02:30 MST 2009


I made some changes to my code. the two patches are attached, but the code
at git://repo.or.cz/Samba/cd1.git is also updated (branch 'cd1').

I tried to reproduce this error using your git tree, but with the
> ldb_msg_add_string() for "invocationID" removed from
> kccsrv_create_connection(). I didn't see the error you have described.

this error was happening because I was using the return of
samdb_ntds_settings_dn() and modifying it, so I was modifying the same
pointer that Samba uses internally. now I'm just copying the DN to a new one
and I can change it safely. thanks Tridge for pointing this out!

now the nTDSConnection objects are being created when needed. if some
connection object already exists, it won't be added again. but for now, they
aren't being deleted. if some server stops existing, the connection object
will still lay around (the function kccsrv_apply_connections is actually
only adding connections, for now). instead of a list of new connections, I
think the function kccsrv_apply_connections should now receive a list of
current connections, so it can compare with the nTDSConnection objects. that
way, the function can add new objects (as it already does) and delete
unneeded connection objects. am I right?


Crístian Deives dos Santos Viana [aka CD1]
Sent from Campinas, SP, Brazil
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-implemented-kccsrv_find_connections.patch
Type: text/x-patch
Size: 6200 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20091125/1ecd3092/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-fixed-kccsrv_find_connections.patch
Type: text/x-patch
Size: 9499 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20091125/1ecd3092/attachment-0001.bin>

More information about the samba-technical mailing list