"const" patches

Matthias Dieter Wallnöfer mdw at samba.org
Fri Nov 20 09:27:09 MST 2009

Hi Stefan,

thank you very much for appying the patches! If you would like to review also the restant part (those for s4) please consider my "const" branch: http://repo.or.cz/w/Samba/mdw.git/shortlog/refs/heads/const.


--- Stefan (metze) Metzmacher <metze at samba.org> schrieb am Fr, 20.11.2009:

Von: Stefan (metze) Metzmacher <metze at samba.org>
Betreff: Re: "const" patches
An: mdw at samba.org
CC: "Samba Technical Mailinglist" <samba-technical at lists.samba.org>
Datum: Freitag, 20. November 2009, 15:25

Matthias Dieter Wallnöfer schrieb:
> Hi all,
> after some rework and improvements (especially some very good suggestions by abartlet - Thanks to him!) these are those four patches which I would see to be applied to the common codebase in the "master" branch. There is one commit for the TDB tools, one for the ICONV test, one for the NBT library and the last one for the string lists.
> I hope to get some constructive comments to be able to finish this work.

I'll push 3 patches to master, after make test is finished.

I think this is wrong as cname is maybe the talloc chunk with the scope
at the end, but with a \0 in the middle. We should not expose such a
string to the caller, as the caller may want to use

-    r->name = talloc_strdup(ndr->current_mem_ctx, cname);
-    NDR_ERR_HAVE_NO_MEMORY(r->name);
-    talloc_free(cname);
+    r->name = talloc_steal(ndr->current_mem_ctx, cname);


Do You Yahoo!?
Sie sind Spam leid? Yahoo! Mail verfügt über einen herausragenden Schutz gegen Massenmails. 

More information about the samba-technical mailing list