Commit: 1169dd3b50dfefa59b56cd1897bcd0b6c2ffb3be

[Kamen Mazdrashki]

Hi,

Recent commit 
http://git.samba.org/?p=samba.git;a=commitdiff;h=1169dd3b50dfefa59b56cd1897bcd0b6c2ffb3be
added function ldb_msg_add_dn(), which is great.

However, could you plese consider renaming this function to something 
like ldb_msg_add_dn_string() (ldb_msg_add_string_dn()... whatever) 
- this way it will be obvious it adds string representation of the DN, 
not the DN itself.

Also, not copying linearized DN string could lead to some very
tricky to resolve bugs. It seems replaces in ldb_map_inbound.c 
are exactly this case - DN string is allocated in 'dn' context, 
but the it is expected to live in 'ac->local_msg' context.

Just few thoughts from me :)

Cheers,
Kamen Mazdrashki
kamen.mazdrashki at postpath.com
http://repo.or.cz/w/Samba/kamenim.git
-------------------------------------
CISCO SYSTEMS BULGARIA EOOD
http://www.cisco.com/global/BG/