[PATCH] new function ldb_msg_add_dn

Crístian Viana cristiandeives at gmail.com
Thu Nov 19 11:28:08 MST 2009


I wrote this new patch adding a new function (ldb_msg_add_dn). I also
updated some places where this new code should be used, but in some of them
I'm not even sure if the change is equivalent. the function ldb_msg_add_dn
uses ldb_dn_get_linearized to get the string form of the DN but in some
parts of the code the function ldb_dn_alloc_linearized is used. I'm not sure
if I can update that code in this situation.

there are 3 files that add a DN to an ldb_msg which I couldn't update the
code because their DN strings are also used somewhere else. they
are lib/ldb/ldb_map/ldb_map.c, libnet/libnet_become_dc.c and
libnet/libnet_site.c. for example, in the libnet/* files there's a
struct libnet_BecomeDC_state and it has a field holding the string DN, and
that field is passed to ldb_msg_add_string and also in other places. so I
don't know if I should change them too.

any comments would be highly appreciated.


Crístian Deives dos Santos Viana [aka CD1]
Sent from Campinas, SP, Brazil
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-added-new-function-ldb_msg_add_dn.patch
Type: application/octet-stream
Size: 4197 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20091119/e5d8b9a8/attachment-0001.obj>

More information about the samba-technical mailing list