[PATCH] s4-drs: Synchronous Implementation of generated ParentGUID

tridge at samba.org tridge at samba.org
Wed Nov 18 15:30:54 MST 2009

Hi Fernando,

 > This patch constructs the parentGUID in a synchronous manner when it is
 > asked for on a search.

Like the other two patches, this is very close. Just some minor issues.

 > +		/* if there is no parentGUID for this object, then return */
 > +		if(ret == LDB_ERR_NO_SUCH_OBJECT){
 > +			return LDB_SUCCESS;
 > +		}else{
 > +			return ret;
 > +		}

as in my previous comments, try to make the whitespace around if
statements follow the conventions in the rest of Samba (also around
the 'else').

 >  	for (a=0;ac->attrs && ac->attrs[a];a++) {
 >  		for (i=0;i<ARRAY_SIZE(search_sub);i++) {
 >  			if (ldb_attr_cmp(ac->attrs[a], search_sub[i].attr) == 0 &&
 > -			    search_sub[i].replace) {
 > +				search_sub[i].replace) {
 > +
 >  				if (!search_attrs) {

similar to your 2nd patch, the above doesn't seem to actually change
anything, so it should not be in the patch. It is very easy for this
to happen when you are editing code and then put some code back the
way it was. The trick is to use "git diff" to look at what you have
actually changed and ensure that you haven't changed any formatting

Cheers, Tridge

More information about the samba-technical mailing list