[PATCH] s4-drs: Synchronous Implementation of generated ParentGUID - ToDo List ParentGUID fix

tridge at samba.org tridge at samba.org
Wed Nov 18 15:34:28 MST 2009

Hi Fernando,

 > Sorry for that! I thought it should be incremental. I just sent the 3
 > patches the way you asked for!

thanks, much appreciated.

 > I was trying this way because I was returning a NULL GUID* when the object
 > doesn't have a parent, so the caller could know when there is just no
 > parentGUID and when an error happened.

ahh, ok

 > Now I changed the approach: If the object doesn't have a parent, then it
 > returns LDB_ERR_NO_SUCH_OBJECT and when it isn't possible to get the
 > objectGUID of the parent, it returns LDB_ERR_NO_SUCH_ATTRIBUTE. Do you think
 > this approach is a suitable solution?

yes, I think that is much better

 > Sorry (2), I thought that function would help... Now I changed it to
 > dsdb_msg_add_guid(), but I put the attr_name parameter, which tells the name
 > of the attribute to be added. That allows to add either objectGUID or
 > parentGUID to a message. Does it fit to what you had in mind?

yes, exactly. I think these two new functions are generic enough to go
into util.c, and I think there are several existing places in Samba
that could use them. If you have time, it would be good to send a
separate patch that takes advantage of the new functions to tidy up
and simplify some existing code.

Cheers, Tridge

More information about the samba-technical mailing list