s4:WINREG RPC server - remove a "talloc_free"

[Andrew Bartlett]

On Tue, 2009-11-17 at 12:57 -0600, Matthias Dieter Wallnöfer wrote:
> The branch, master has been updated
>        via  a31838e... s4:WINREG RPC server - remove a "talloc_free"
>        via  5c6c261... s4:provision_users.ldif - Descriptions generally begin with a majuscle
>       from  dea569d... s4:SAMLDB DSDB module - Add "\n"s on debug messages
> 
> http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
> 
> 
> - Log -----------------------------------------------------------------
> commit a31838eb3c40f4b70c629f94620f435214e414d4
> Author: Matthias Dieter Wallnöfer <mwallnoefer at yahoo.de>
> Date:   Tue Nov 17 19:56:14 2009 +0100
> 
>     s4:WINREG RPC server - remove a "talloc_free"
>     
>     I assume that this "talloc_free" isn't necessary since the DCERPC server frees
>     the handle itself (we got always warnings about this).

Matthias,

What made you assume that?

If you look at commit a0a787ad78a72b1bb9e7f9f7f28d18a4023a666b, you will
see that the opposite is the case: it's vital to talloc_free() handles
when we close them - it is the talloc call that does the free. 

Any free the DCE/RPC server does is at shutdown, and way too late,
leaving a memory leak in the meantime. 

Please explain further or revert.

Andrew Bartlett

-- 
Andrew Bartlett                                http://samba.org/~abartlet/
Authentication Developer, Samba Team           http://samba.org
Samba Developer, Cisco Inc.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20091118/86e172b5/attachment.pgp>