s4:SAMLDB module

[Andrew Bartlett]

On Mon, 2009-11-16 at 10:55 -0600, Matthias Dieter Wallnöfer wrote:
> The branch, master has been updated
>        via  5c54c73... s4:SAMLDB module
>       from  e853dd7... Revert "s4:dsdb/repl/replicated_objects - Applicate also here the new "lDAPDisplayName" generator"
> 
> http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
> 
> 
> - Log -----------------------------------------------------------------
> commit 5c54c73c0ec14e391cd58481249b1eda752d4798
> Author: Matthias Dieter Wallnöfer <mwallnoefer at yahoo.de>
> Date:   Mon Nov 16 17:57:50 2009 +0100
> 
>     s4:SAMLDB module
>     
>     - Add more "\n" to make sure that error messages are displayed immediately

I was pretty sure we changed the pattern not to have \n in LDB error
messages and debug output.  If the error message isn't displayed, then
the bug is elsewhere. 

>     - Add a "NULL" in a attribute list

This is critical, and an often-repeated bug that is a real pain to track
down.  Nice catch!

> -----------------------------------------------------------------------
> 
> Summary of changes:
>  source4/dsdb/samdb/ldb_modules/samldb.c |   28 ++++++++++++++--------------
>  1 files changed, 14 insertions(+), 14 deletions(-)
> 
> 
> Changeset truncated at 500 lines:
> 
> diff --git a/source4/dsdb/samdb/ldb_modules/samldb.c b/source4/dsdb/samdb/ldb_modules/samldb.c
> index bfc4cac..9cfdb37 100644
> --- a/source4/dsdb/samdb/ldb_modules/samldb.c
> +++ b/source4/dsdb/samdb/ldb_modules/samldb.c
> @@ -207,7 +207,7 @@ static int samldb_get_parent_domain_callback(struct ldb_request *req,
>  			/* one too many! */
>  			ldb_set_errstring(ldb,
>  				"Invalid number of results while searching "
> -				"for domain object!");
> +				"for domain object!\n");
>  			ret = LDB_ERR_OPERATIONS_ERROR;
>  			break;
>  		}
-- 
Andrew Bartlett                                http://samba.org/~abartlet/
Authentication Developer, Samba Team           http://samba.org
Samba Developer, Cisco Inc.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20091117/d8ae207c/attachment.pgp>