s4:dsdb/repl/replicated_objects - Applicate also here the new "lDAPDisplayName" generator

[Matthias Dieter Wallnöfer]

Andrew,

thanks for pointing out. Will revert immediately.

Matthias

Andrew Bartlett wrote:
> On Sun, 2009-11-15 at 07:27 -0600, Matthias Dieter Wallnöfer wrote:
>    
>> The branch, master has been updated
>>         via  cc08074... ldb:python bindings - add a context on "py_ldb_delete"
>>         via  6cf43db... s4:ldap.py - enhance schema addition test
>>         via  df95d5c... s4:dsdb/repl/replicated_objects - Applicate also here the new "lDAPDisplayName" generator
>>         via  2c7294b... s4:SAMLDB module - Add support for required and generated schema attributes
>>         via  da3d471... s4:samdb util - add a call for generating a correct "lDAPDisplayName"
>>        from  bf4e8ba... s3: Fix a memleak in sys_popen
>>
>> http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
>>
>>
>> - Log -----------------------------------------------------------------
>>      
>    
>> commit df95d5c29292968b465bff24c3cf78800677a4d4
>> Author: Matthias Dieter Wallnöfer<mwallnoefer at yahoo.de>
>> Date:   Sat Nov 14 20:14:45 2009 +0100
>>
>>      s4:dsdb/repl/replicated_objects - Applicate also here the new "lDAPDisplayName" generator
>>
>>      Also here we've to be sure to generate the attribute correctly if it doesn't
>>      exist yet.
>>      
> What made you think that the "lDAPDisplayName" generator was required
> here?  What tests failed without this in place?
>
> This is the code to handle replication of objects with DRS, and is used
> to fill out 'cn', 'ou', 'dc' etc from the marked RDN attribute when
> replicating from another domain controller over LDAP.  It has nothing to
> do with the generation of an lDAPDisplayName for a new schema element.
>
> Also, when changing any of the code in the replication area, you need to
> do a full vampire and 'dcpromo' test from a Windows client.  (It may not
> always pass the dcpromo, but the results and from that and proposed
> changes should be discussed with one of those on the team involved in
> that code).
>
> (I have also the RPC-DSSYNC test, which when operational should also
> detect this kind of mistake)
>
> Please revert.
>
> Thanks,
>
> Andrew Bartlett
>