[SCM] Samba Shared Repository - branch master updated

[Jeremy Allison]

On Thu, Nov 12, 2009 at 08:51:45PM +0100, Volker Lendecke wrote:
> On Thu, Nov 12, 2009 at 01:49:11PM -0600, Jeremy Allison wrote:
> > The branch, master has been updated
> >        via  83c2c17... Ensure every return path initializes presult as NULL. Ensures no crashes in calling code that forgets to init return as null. Jeremy.
> >       from  21644c5... s4:heimdal_build: allow flex-2.5.35 with bison-2.3
> > 
> > http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
> > 
> > 
> > - Log -----------------------------------------------------------------
> > commit 83c2c177a5e86d04da37384f1f04230c8274e1e6
> > Author: Jeremy Allison <jra at samba.org>
> > Date:   Thu Nov 12 11:49:54 2009 -0800
> > 
> >     Ensure every return path initializes presult as NULL.
> >     Ensures no crashes in calling code that forgets to
> >     init return as null.
> 
> Hmmm. The convention for a while was to not touch output
> arguments if the result was not NT_STATUS_OK. Any particular
> reason for this change in convention?

Yeah - for this code, bug 6889 which was caused by
calling code not initializing the return val and thus
crashing winbindd. I looked at some of the other callers
in the auth code and they were making the same mistake,
so I just made it safe.

Jeremy.