Use after talloc_free...
Rusty Russell
rusty at rustcorp.com.au
Thu Nov 12 05:44:21 MST 2009
On Thu, 12 Nov 2009 12:10:39 pm Jeremy Allison wrote:
> On Thu, Nov 12, 2009 at 12:05:19PM +1030, Rusty Russell wrote:
>
> > To be clear: I *don't* want magic NULL-ing. If you want to NULL a pointer
> > because you're going to re-use it, I'd much rather that be explicit. I want
> > an instant way to detect use-after-free, whether it be double-free or other
> > cases where NULL would be treated as special and mask the bug.
>
> I understand your position on this, but the NULL-ing of TALLOC_FREE is baked
> into a lot of the Samba3 code, which would break without it.
Sure, if we get consensus, we'd keep TALLOC_FREE, and maybe wean over
gradually as code churns. I don't think there's any hurry.
Thanks,
Rusty.
More information about the samba-technical
mailing list