Use after talloc_free...
simo
idra at samba.org
Wed Nov 11 20:38:10 MST 2009
On Thu, 2009-11-12 at 12:28 +1030, Rusty Russell wrote:
> On Thu, 12 Nov 2009 12:59:28 am simo wrote:
> > On Wed, 2009-11-11 at 21:09 +1030, Rusty Russell wrote:
> > > So if we're going to promote this in talloc, I'd like to do it differently...
> >
> > Rusty I use talloc_zfree() in the sssd code.
> > It is compact and should express the idea you are zeroing the pointer.
> > I'd prefer it over longer constructs or the TALLOC_FREE all caps way.
>
> OK, seems like we should definitely put *something* in talloc, since this
> seems to be best practice.
>
> See previous mail detailing my reservations about NULL-ing and implicit
> arg modifying tho...
What's wrong with "implicit" arg modifying ?
I mean that's the only reason to use TALLOC_FREE(), it's not like you
are going to be confused about that, or are you ?
Simo.
--
Simo Sorce
Samba Team GPL Compliance Officer <simo at samba.org>
Principal Software Engineer at Red Hat, Inc. <simo at redhat.com>
More information about the samba-technical
mailing list