PATCHS: manipulation of NT ACL in command line

Andrew Bartlett abartlet at samba.org
Tue Nov 10 04:17:01 MST 2009


On Tue, 2009-11-10 at 10:33 +0100, Stefan (metze) Metzmacher wrote:
> Matthieu Patou schrieb:

> > 0003-S4-Allow-an-optional-parameter-in-generated-python-b.patch: This
> > patch for the PIDL generator. With this patch the generated python code
> > allow the specification of a "notallflag" so that either
> > ndr_pull_struct_blob or ndr_pull_struct_blob_all can be used. This patch
> > follow the talk that I had with metze today on IRC about on how to
> > workaround the wrong calculation of consumed bytes when unpacking an
> > xattr.NTACL object
> 
> I didn't noticed we already have a $got_relative variable there,
> I think the real problem is that we didn't detect that relative pointers
> are used...

Perhaps if no pointers at all are used, then we don't trigger it?  It's
my code, so I'm sure that there are still corner cases (I'm no pidl
hacker...)

> We could fix that (maybe impossible because we reference types defined
> in other idl files) or remove this check completely and always let the
> caller pass in the not all flag (I'd prefer this one).
> 
> I'd like the callers to use keywords, something like this:
> obj.ndr_unpack(blob, notall=true)
> instead of obj.ndr_unpack(blob, true)

That would work, but I would like to know why my pidl hack doesn't work.
Perhaps it needs to recurse down the structures?

Andrew Bartlett

-- 
Andrew Bartlett                                http://samba.org/~abartlet/
Authentication Developer, Samba Team           http://samba.org
Samba Developer, Cisco Inc.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20091110/efb63a6f/attachment.pgp>


More information about the samba-technical mailing list