[IPA] SID allocation using DNA plugin

[Endi Sukma Dewata]

Andrew,

I'm still trying to test the patches. So far I'm getting
inconsistent behavior, sometimes the server crashes for different
reasons. Please take a look at the attached valgrind and gdb output.
Thanks!

--
Endi S. Dewata


----- "Andrew Bartlett" <abartlet at samba.org> wrote:

> On Fri, 2009-11-06 at 14:27 -0500, Endi Sukma Dewata wrote:
> > Andrew,
> > 
> > ----- "Andrew Bartlett" <abartlet at samba.org> wrote:
> > 
> > > > I think ideally this problem should be addressed using
> polymorphism
> > > > instead of function pointer. So we need to create 2 subclasses
> of
> > > > the ProvisionBackend called OpenLDAPBackend and FDSBackend. The
> > > > base class should include an empty post_setup() and this should
> be
> > > > overriden in the FDSBackend. In the main code the code should
> > > > instantiate the class as follows:
> > > > 
> > > >     if backend_type == "fedora-ds":
> > > >         provision_backend = FDSBackend(...)
> > > > 
> > > >     if backend_type == "openldap":
> > > >         provision_backend = OpenLDAPBackend(...)
> > > > 
> > > >     provision_backend.post_setup()
> > > > 
> > > > We could also do this on other parts of the code to cleanly
> separate
> > > > FDS and OpenLDAP code. What do you think?
> > > 
> > > Yes, this is the approach I was trying to head towards.  Just make
> sure
> > > we don't run the LDB specific functions when we are trying to use
> > > OpenLDAP or Fedora DS. 
> > 
> > Please take a look at the attached patches. These patches and the
> previous
> > patch about the relax control are available in this repository:
> > 
> > http://github.com/endisd/samba/commits/development/
> > 
> > The ProvisionBackend now has become a base class for LDBBackend,
> > ExistingBackend, FDSBackend, and OpenLDAPBackend. All
> backend-specific
> > attributes have been moved into the appropriate classes. Am I in
> the
> > right direction?
> 
> Do these pass 'make test' and otherwise work?
> 
> (my dsdb-dn branch may fix the OpenLDAP backend)
> 
> In any case, the code looks very reasonable, I look forward to
> merging
> it!
> 
> Andrew Bartlett
> 
> -- 
> Andrew Bartlett                               
> http://samba.org/~abartlet/
> Authentication Developer, Samba Team           http://samba.org
> Samba Developer, Cisco Inc.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: valgrind.out
Type: application/octet-stream
Size: 4760 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20091109/20c42dad/attachment.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: gdb.out
Type: application/octet-stream
Size: 12407 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20091109/20c42dad/attachment-0001.obj>