Refactor of Binary DN code

Stefan (metze) Metzmacher metze at samba.org
Fri Nov 6 06:44:50 MST 2009


Andrew Bartlett schrieb:
> On Thu, 2009-11-05 at 18:02 +1100, Andrew Bartlett wrote:
>> I wanted to bring your attention to my GIT branch dsdb-dn
>> http://gitweb.samba.org/?p=abartlet/samba.git/.git;a=shortlog;h=refs/heads/dsdb-dn
>>
>> This creates a new struct dsdb_dn and associated functions, taking over
>> from ldb_dn for the DN+Binary and DN+String code.
>>
>> I feel this is a cleaner separation than we had previously, and should
>> fix some reported issues with the OpenLDAP backend.  (We need to be able
>> to deal with the linear form of these DNs as a whole, and as the
>> 'normal' part differently in different portions of the code).
>>
>> It also adds functions to allow these DNs to be searched for correctly,
>> as the DN is now able to be casefolded independently of the binary or
>> string prefix. 
>>
>> The next step is to write specific tests for this new code, and to
>> validate that I've not broken 'net vampire' and replication (for which
>> this code was added in the first place). 
> 
> I've pushed an updated set of changes to my branch.
> 
> The problem I have, aside from a small segfault mdw will patch shortly
> in his ValidatePassword code, is that dcpromo on a new second Windows
> 2008 DC fails with:
> 
> "The replication system has encountered an internal error"
> 
> while replicating cn=configuration

Does it work without your changes?

metze


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 260 bytes
Desc: OpenPGP digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20091106/194aade3/attachment.pgp>


More information about the samba-technical mailing list