LIBREPLACE_LIBS in s3 (Re: [SCM] Samba Shared Repository - branch master updated)

Sun Nov 1 03:18:15 MST 2009

Hi Björn.

> - Log -----------------------------------------------------------------
> commit a80a0b7728de21e992f8f0b3e31b600441a6535d
> Author: Björn Jacke <bj at sernet.de>
> Date:   Sat Oct 31 10:37:44 2009 +0100
> 
>     s3:Makefile: add LIBREPLACE_LIBS for talloc, tdb and wbclient

I think talloc and tdb should not get LIBREPLACE_NETWORK_LIBS
linked in... they don't include "system/network.h" from libreplace.
And the standalone builds also doesn't use LIBREPLACE_NETWORK at all.

I think it's a bit confusing to have LIBREPLACE_LIBS as the same
as LIBREPLACE_NETWORK_LIBS.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 260 bytes
Desc: OpenPGP digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20091101/4cb7c2d5/attachment.pgp>