tight loop in tdb_find()
jra at samba.org
Thu May 21 20:27:48 GMT 2009
On Thu, May 21, 2009 at 03:42:12PM -0400, Jim McDonough wrote:
> On Thu, May 21, 2009 at 3:36 PM, Jeremy Allison <jra at samba.org> wrote:
> > On Thu, May 21, 2009 at 02:41:12PM -0400, Jim McDonough wrote:
> >> Attached is a patch to 3.3 which will bail out of a tight infinite
> >> loop in tdb_find(). I'm sending back the error code as
> >> TDB_ERR_CORRUPT. Make sense?
> > +1 - looks an obvious fix to me. Have you ever seen
> > a tdb in that state ?
> Yep, after a power failure. And we've got similar checks in the
> traverse code, as someone else found it this way, too.
> I'm just trying to make sure I'm not breaking something else down the line...
No, that change looks completely safe to me. Do you want
to add in the traverse code changes too ?
More information about the samba-technical