[PATCH]: wbc: expand wbcAuthUserParams to pass
jerry at plainjoe.org
Tue May 19 22:25:57 GMT 2009
-----BEGIN PGP SIGNED MESSAGE-----
Steven Danneman wrote:
>> - From a style PoV, I would have probably included the two new
>> char *'s at the top level and not created a new struct. It should
>> be self-explanatory whether or not to use the original username/domain
>> based on the wbcAuthUserParams.level value and whether the pointer(s)
>> is (are) NULL. Correct?
> Hey Jerry,
> Thanks for the input. The problem with this approach is that it breaks
> ABI compatibility with client apps using previous versions of
> libwbclient. Adding the char*s to the top, will shift the memory
> location of all other variables in the wbcAuthUserParams structure.
True. But I think you have already broken ABi compatibility in
spirit at least. But I'll concede your point.
> There's also the issue, at least through the wb pipe interface, of not
> easily being able to pass NULLs from client to server.
Ahh...Yeah. I hadn't considered that.
> The versioned structure really seems like the cleanest approach, most
> backwards compatible approach.
I'm convinced with the exception of the one outstanding
piece of mail about using the target hostname from from the
blob in the v2Response. Granted that may be considered too
much of a hack.
"What man is a man who does not make the world better?" --Balian
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
-----END PGP SIGNATURE-----
More information about the samba-technical