FW: [PATCH] Stop packet_recv greediness, stop using event_add_timed

Andrew Bartlett abartlet at samba.org
Mon May 18 21:51:35 GMT 2009

On Mon, 2009-05-18 at 17:32 +0100, Sam Liddicott wrote:
> Volker; hows this for style and intrusiveness?
> (It still needs modifying to avoid reading most of the queued bytes in 
> cases where the packet size isn't known).
> I don't yet have the data on how it affects throughput, but it does have 
> the effect of letting a server send out it's responses ASAP rather than 
> wait until all requests have been processed.
> Further work needs doing on fairness between different sockets, but that 
> will follow later, as Tom and I (mostly Tom) are still looking at those 
> cases.

Urgh.  I would really like to avoid 'one byte left on the socket' games.
The GnuTLS library tried to play those games, and we lost out badly when
something subtle broke it.  I would prefer a way to indicate to the
event lib that it should do this timed event at the end of the queue, if
that's what we actually need (otherwise, it all breaks if the event lib
changes it's ordering). 

Andrew Bartlett

Andrew Bartlett
Authentication Developer, Samba Team           http://samba.org
Samba Developer, Red Hat Inc.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : http://lists.samba.org/archive/samba-technical/attachments/20090519/cac4407a/attachment.bin

More information about the samba-technical mailing list