[PATCHES] Consolidating create/delete account paths

simo idra at samba.org
Sun May 17 01:33:57 GMT 2009

After looking at bug #6333 I and Volker had a brief discussion about
consolidating account creation/delete paths between the passdb and the
smbpasswd and pdbedit utilities.

The following 2 patches consolidate all operation through the common
function local_password_change() which has been changed as well to use
the passdb pdb_create_user() and pdb_delete_user() functions.

The function name is a bit disguising as this function does much more
than simply change passwords, but I didn't change it for now.

There is one major change that the first patch introduces and it is the
reason why I am asking for review before committing.

The reworked local_password_change() now allows you to create/delete
also *unix* users if you have configured add/delete user script or are
using ldapsam:editposix

I think this is something our users have been wanting and expecting for
a while, but it is nonetheless a change in behavior.

If you have not configured scripts there is of course no change in

The patches have been minimally tested, but they seem to work.
If not already fixed, I believe this patch will probably let us close
also #3535

Please review and comment.


Simo Sorce
Samba Team GPL Compliance Officer <simo at samba.org>
Principal Software Engineer at Red Hat, Inc. <simo at redhat.com>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Consolidate-user-create-delete-paths-in-smbpasswd.patch
Type: text/x-patch
Size: 16193 bytes
Desc: not available
Url : http://lists.samba.org/archive/samba-technical/attachments/20090516/bc1f9691/0001-Consolidate-user-create-delete-paths-in-smbpasswd.bin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-Consolidate-create-delete-account-paths-in-pdbedit.patch
Type: text/x-patch
Size: 27672 bytes
Desc: not available
Url : http://lists.samba.org/archive/samba-technical/attachments/20090516/bc1f9691/0002-Consolidate-create-delete-account-paths-in-pdbedit.bin

More information about the samba-technical mailing list