[PATCH]: Fix the bug tevent_req_poll() loops forever(was: [PATCH] (partial) tevent_req_poll() loops for ever....)

boyang boyang at samba.org
Sat May 16 18:04:41 GMT 2009


Volker Lendecke wrote:
> On Sun, May 17, 2009 at 12:47:13AM +0800, boyang wrote:
>   
>> boyang wrote:
>>     
>>> Jeremy Allison wrote:
>>>   
>>>       
>>>> Ok, I've reviewed this carefully (with some test code) and you're
>>>> completely correct.
>>>>
>>>> We'll have to deal with this, I've talked to Volker and he has
>>>> some ideas on how to deal with this efficiently.
>>>>   
>>>>     
>>>>         
>>>   
>>>       
>> Hi, everyone:
>>      Can someone please have a look at this? If it looks ok, I'll push
>> it to master. :-) Because there is change to struct cli_state, I need
>> someone to comment on this to see if it has any side effect, or
>> anything. :-)
>>      Thanks!
>>     
>
> There's no way to get around the special case in so many
> places? 
I cannot figure out another way to do it. We cannot distinguish
pipe_local and pipe_ncalrpc with the information in rpc_pipe_client.....
> Sooner or later someone will forget to set that
> correctly.
>
> Volker
>   


-- 
Bo Yang, Software Engineer, Suse Labs
GPG-key-ID   538C4C1A
Samba Team   boyang at samba.org    http://www.samba.org/
Suse Linux   boyang at suse.de      http://www.novell.com/



More information about the samba-technical mailing list