[PATCH] Have ntvfs_connect() accept union smb_tcon *tcon
instead of char* sharename
Sam Liddicott
sam at liddicott.com
Thu May 14 08:01:27 GMT 2009
Metze, regarding the comment:
ntvfs_connect functions are required to fill in the
tcon->tconx.out.*_type
fields, for RAW_TCON_TCONX, perhaps something like:
if (tcon->generic.level == RAW_TCON_TCONX) {
tcon->tconx.out.fs_type = ntvfs->ctx->fs_type;
tcon->tconx.out.dev_type = ntvfs->ctx->dev_type;
}
We could have the send function copy these from ntvfs as of old (in the
case where they are left at NULL) which may simplify things, but I
wonder if it would simplify to the point of obscurity - where the
current requirement to fill these in ends up being instructive because
new coders can see that they are filled in.
What is your opinion on this?
(I think it is certainly worth keeping these fields in ntvfs->ctx)
Sam
More information about the samba-technical
mailing list