[PATCH] Patches come from Centrify Corp.

Zhou Weikuan weikuan.zhou at sinobot.com.cn
Tue May 12 10:16:21 GMT 2009


Hello all,
I'm working for Centrify Corp. My company is going to open our patches to samba source code. The base samba version is 3.0.32, and the patches can also be applied for later versions with some modifications manually:
The patches are for the purposes listed as below:
1)  cliconnect.c.patch
If we want to do NTLM authentiction, and NTLM authentication require user's samAccountName. So we Added get_sid and get_sam_account functions for getting
sam account by uid first. 

2) clikrb5.c.patch, sasl.c.patch
Win2k8 encryption support, add AES into encryption list. Win2k8 uses AES as the preferred encryption if it runs in win2k8 function level.  If we use `kinit administrator` to create kerberos cache first, and then run `net ads user` without specifying the account explicitly,  net doesn't work. This patch resolves this.

3) smbpasswd.c.patch
Put smb-name in front of the local user when changed the password via smbpasswd, so that the local unix user will not be regarded as ad user and fail to smbpasswd again.

4) srv_srvsvc_nt.c.patch 
Added a lp_pathexist array to save the path status. If the path of the share resource does not exist, don't show it on client. A typical example is that some users' home directory will not be created until the users log in for the first time. But the home directory displays if we visit it from windows even if  it is not there.

5) testparm.c.patch 
Check for invalid uid/gid. 
Samba is sensitive to netative uid/gid pairs; the default guest account for samba is nobody, which is typically assigned -1/-2 on HP-UX.  A workaround is to create an smbnull user in file /etc/passwd with positive uid/gid pair and add the global parameter guest account = smbnull. We patch samba to make it explicitly. 

6) vfs_hpuxacl.c.patch 
initialized pointer before using it, so that SAFE_FREE() won't free an uninitialized pointer.  Or there would be a segmentation fault.


7) winbindd.c.patch 
Limit maximum simutaneous connections to 200. 
>From the code, we guess winbind should limit the maximum simutaneous connections to 200, but the original code seems not to do this.  


Would you like to have a review of these patches please? 
Thanks,
Weikuan Zhou
-------------- next part --------------
A non-text attachment was scrubbed...
Name: cliconnect.c.patch
Type: application/octet-stream
Size: 3034 bytes
Desc: not available
Url : http://lists.samba.org/archive/samba-technical/attachments/20090512/e7c32b21/cliconnect.c.obj
-------------- next part --------------
A non-text attachment was scrubbed...
Name: clikrb5.c.patch
Type: application/octet-stream
Size: 519 bytes
Desc: not available
Url : http://lists.samba.org/archive/samba-technical/attachments/20090512/e7c32b21/clikrb5.c.obj
-------------- next part --------------
A non-text attachment was scrubbed...
Name: sasl.c.patch
Type: application/octet-stream
Size: 711 bytes
Desc: not available
Url : http://lists.samba.org/archive/samba-technical/attachments/20090512/e7c32b21/sasl.c.obj
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smbpasswd.c.patch
Type: application/octet-stream
Size: 1000 bytes
Desc: not available
Url : http://lists.samba.org/archive/samba-technical/attachments/20090512/e7c32b21/smbpasswd.c.obj
-------------- next part --------------
A non-text attachment was scrubbed...
Name: srv_srvsvc_nt.c.patch
Type: application/octet-stream
Size: 6324 bytes
Desc: not available
Url : http://lists.samba.org/archive/samba-technical/attachments/20090512/e7c32b21/srv_srvsvc_nt.c.obj
-------------- next part --------------
A non-text attachment was scrubbed...
Name: testparm.c.patch
Type: application/octet-stream
Size: 1753 bytes
Desc: not available
Url : http://lists.samba.org/archive/samba-technical/attachments/20090512/e7c32b21/testparm.c.obj
-------------- next part --------------
A non-text attachment was scrubbed...
Name: vfs_hpuxacl.c.patch
Type: application/octet-stream
Size: 919 bytes
Desc: not available
Url : http://lists.samba.org/archive/samba-technical/attachments/20090512/e7c32b21/vfs_hpuxacl.c.obj
-------------- next part --------------
A non-text attachment was scrubbed...
Name: winbindd.c.patch
Type: application/octet-stream
Size: 1404 bytes
Desc: not available
Url : http://lists.samba.org/archive/samba-technical/attachments/20090512/e7c32b21/winbindd.c.obj


More information about the samba-technical mailing list