[PATCH] s3: Fix chained sesssetupAndX/tconn messages

Tim Prouty tprouty at samba.org
Sat May 9 00:14:09 GMT 2009


On May 8, 2009, at 5:10 PM, Jeremy Allison wrote:

> On Wed, May 06, 2009 at 03:27:35PM -0700, Tim Prouty wrote:
>> Volker (and any other chaining experts),
>>
>> In master a sesssetupAndX chained with a tconn will not correctly set
>> the TID in the response header.  I'm seeing an XP client send this
>> chained sesssetup/tconn when samba has security = share.  Samba's
>> current behavior is to return a TID of 0 in the smb header rather  
>> than
>> the actual TID.  This patch also updates the UID in the header as
>> well.  I wanted to have someone who knows the chaining code well
>> review this before I push it.
>
> Pushed this as Volker already reviewed this and ok'ed it, and I
> need this fix to make one of my home devices work :-).
>
> Thanks,
>
> Jeremy.

Thanks Jeremy.  I'll work on getting a test written that verifies it  
so we don't regress in the future.

-Tim


More information about the samba-technical mailing list