[SCM] Samba Shared Repository - branch master updated - release-4-0-0alpha7-1312-gf8cc0e8

Stefan (metze) Metzmacher metze at samba.org
Fri May 8 06:29:31 GMT 2009


boyang schrieb:
> Volker Lendecke wrote:
>> Hi, Bo!
>>
>> On Tue, Apr 28, 2009 at 08:52:09PM -0500, Bo Yang wrote:
>>   
>>> diff --git a/source3/libsmb/async_smb.c b/source3/libsmb/async_smb.c
>>> index 6faf96c..17040b8 100644
>>> --- a/source3/libsmb/async_smb.c
>>> +++ b/source3/libsmb/async_smb.c
>>> @@ -604,6 +604,10 @@ bool cli_smb_req_send(struct tevent_req *req)
>>>  	struct cli_smb_state *state = tevent_req_data(
>>>  		req, struct cli_smb_state);
>>>  
>>> +	if (state->cli->fd == -1) {
>>> +		return false;
>>> +	}
>>> +
>>>     
>> Thanks :-)
>>
>> Can you change cli_smb_req_send() and cli_smb_req_iov_send()
>> to return not bool but NTSTATUS and return PIPE_DISCONNECTED
>> in this case? The callers of cli_smb_req_iov_send think this
>> is NT_STATUS_NO_MEMORY which is not the case anymore.
>>   
> Yep. The error here is not precise. sorry for the delay, I'll have a
> look at it asap.
>> Thanks,

Maybe we could better use NT_STATUS_CONNECTION_INVALID or
NT_STATUS_CONNECTION_DISCONNECTED.

metze

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 252 bytes
Desc: OpenPGP digital signature
Url : http://lists.samba.org/archive/samba-technical/attachments/20090508/6ad03240/signature.bin


More information about the samba-technical mailing list