Patch policy -- bug 6318 ?

Michael Adam obnox at samba.org
Tue May 5 19:45:21 GMT 2009


Tim Prouty wrote:
> 
> On May 5, 2009, at 11:46 AM, Jeremy Allison wrote:
> 
> >On Tue, May 05, 2009 at 04:32:17PM +0200, Volker Lendecke wrote:
> >>Hi!
> >>
> >>In bug 6318 Michael posted a patch that fixes some bug. He
> >>ported back a series of 4 patches that also do some good
> >>refactoring in master/3.4. However, for 3.3 there could be a
> >>much smaller patch that also fixes the problem without the
> >>refactoring. The refactoring consolidates code and includes
> >>a lot of "-" in the patch, but it's larger than strictly
> >>necessary.
> >>
> >>What kind of patch do we want for 3.2/3.3?
> >
> >Personally I'd rather go for the smaller patch
> >without the refactoring, and keep the refactoring
> >in the unreleased branches. IMHO we should be trying
> >to do point patches only for specific bugs in the
> >3.3/3.2 code trees. Just my 2 cents.
> 
> I agree.  To ensure the stability of maintenance releases, we should  
> be adding the minimum code necessary to fix the bug.

Agreed.

I have updated the bug #6318 with a very minimal
patch and Volker has already given his +1 on that.

Cheers - Michael

-- 
Michael Adam <ma at sernet.de>  <obnox at samba.org>
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.SerNet.DE, mailto: Info @ SerNet.DE
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 206 bytes
Desc: not available
Url : http://lists.samba.org/archive/samba-technical/attachments/20090505/393d9ecc/attachment.bin


More information about the samba-technical mailing list